Check parsing of _scroll_id in ES response with some kind of trouble

seznam / elasticlient

C++ Elasticsearch client library

https://seznam.github.io/elasticlient/

MIT License

132 stars 67 forks source link

Check parsing of _scroll_id in ES response with some kind of trouble #18

Open mbumba opened 3 years ago

mbumba commented 3 years ago

I noticed that _scroll_id is parsed only if response from ES is absolutely correct (https://github.com/seznam/elasticlient/blob/master/src/scroll.cc#L111). Maybe it should be parsed whenever _scroll_id arrived in ES response. ES documentation says: only the most recently received _scroll_id should be used.