search

seznam / flexp

BSD 3-Clause "New" or "Revised" License
8 stars 3 forks source link

Add/integrate TqdmLoggingHandler. Resolves #33. #34

Closed ofilip closed 5 years ago

alaneckhardt commented 5 years ago

I'm personally not really fun of tqdm, especially for log running background tasks, which is 90% of my scripts. It looks like it is the default behaviour in logging. I'd love to have a switch that selects the way to log, and defaults to current style log.

ofilip commented 5 years ago

But this change doesn't affect how things are logged (it still logs to file), it only allows for logging in tqdm loop. If you don't use tqdm, it will work the same way (or at least I hope so).

-- Ondřej Filip ondrejfilip@seznam.cz +420 721 22 50 10 (STS)

čt 11. 4. 2019 v 16:07 odesílatel Alan Eckhardt notifications@github.com napsal:

I'm personally not really fun of tqdm, especially for log running background tasks, which is 90% of my scripts. It looks like it is the default behaviour in logging. I'd love to have a switch that selects the way to log, and defaults to current style log.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/seznam/flexp/pull/34#issuecomment-482129121, or mute the thread https://github.com/notifications/unsubscribe-auth/ADKwC0V8JyF50QY6oQSvlmst0STziURRks5vf0GYgaJpZM4cke7Z .

alaneckhardt commented 5 years ago

Aha! Sorry for the confusion, in that case it's fine.