search

sezzle / sezzle-magento2

Apache License 2.0
5 stars 3 forks source link

Add sort order for payment method in admin config. #6

Closed drew7721 closed 4 years ago

drew7721 commented 4 years ago

Payment methods should have a sort order fields so we can sort them on the checkout.

This adds the admin config so that users can properly sort the Sezzle payment method.

Signed-off-by: Alex Ghiban drew7721@gmail.com

drew7721 commented 4 years ago

I see you guys implemented this, thanks! I do believe it's better to keep this config ordered at the end as it's a config shared by all payment processors and it's a default M2 config. Just a suggestion.

I see the version changed from 4. to 5. - Do your versions respect Semantic Versioning? In other words, will this jump to v5 will break backward compatibility?

As I've just started implementing your module in our storefront, it would be nice to have more detailed release notes on such major version changes to have a better idea if it will break or not compatibility with our code and our implementation.

Thank you.

arijit-sezzle commented 4 years ago

We do maintain Semantic Versioning. This is a major release and for this reason, you see the jump. You will be able to jump to previous versions but in that case, you will lose some important features.

We have introduced InContext Checkout Solution and also contain some other fixes from 5.*

You can also check the https://github.com/sezzle/sezzle-magento2/README.md for 4. and 5. for the comparing the changes.

And, thanks for your suggestion on the position of sort_order and this has been implemented now. So, you can disregard the merge conflict. For any other queries, please reach out to merchantsupport@sezzle.com.