sf-inc / music_control

More control over Minecraft musics!
https://modrinth.com/mod/music-control
MIT License
6 stars 6 forks source link

Incorrect song names #18

Closed Qendolin closed 3 months ago

Qendolin commented 2 years ago

When a resource pack overwrites the default music the mod still shows vanilla track names. Please detect when a track is changed by a resource pack and either get the song name from the music file's metadata or display nothing at all.

charlyb01 commented 2 years ago

Hi, thanks for the report! Actually, I thought that replacing minecraft musics with a resource pack would display the right name if we set the name in the lang file but it seems not. I'll see what I can do ;)

EGOIST1372 commented 2 years ago

@charlyb01 Hi there is also this wrong name that I get from nether. I have no custom music or resources so idk what causing it image

charlyb01 commented 3 months ago

Hello, I checked this issue again and actually it works. Of course, if you don't set your own language file to update the name of the music, I won't update the displayed name, as I told you. But you can add a lang file with the updated name. I think it has always work, but I tried without thinking too much I guess, so anyway now it's sure it works.
What you could do wrong when doing this, is setting the lang file inside the same namespace, which is minecraft when you override its music. However, it must be set in a new directory/namespace as music translation is not vanilla, in music_control.

So, a resource pack overriding minecraft music could look like: