[v1.6.0?] Many new features and improvements

[naturecodevoid]

Changes in this PR:

• Format parts of the project with IntelliJ
• Update dependencies
• en_us updates for new features and grammar fixes
• bumped version to 1.6.0
• new features and improvements
  • Volume increment
  • New config value, configures how much the volume goes up by when using volume up/down controls (default: 5%)
  • High volume
  • New config value, allows the volume to go up to 200% when using volume up/down controls (default: off)
  • Improved config
  • There are now categories and I've added tooltips to en_us
  • Improved volume display
  • When using volume up/down, it now adds a percent (%) symbol to the end of the displayed text

Please tell me if you want me to translate for the other languages (it would be using google translate) and what you think about this PR. I've also added this all to the changelog but I haven't added myself to the authors list in fabric.mod.json.

[naturecodevoid]

In english music doesn't have a plural form, I believe that the best solution is songs

[charlyb01]

I did not know about that, but what I meant is that a music is more general than a song is. A song is, I believe, a music with lyrics, "sang" by a singer. But that's not a big deal

[charlyb01]

• Format parts of the project with IntelliJ: was not really necessary to commit this kind of thing as I was reworking the code etc but anyway
• Update dependencies: not necessary as long as there is no major update
• en_us updates for new features and grammar fixes: thanks!
• bumped version to 1.6.0: more like a 1.5.4 but if you want, next time leave it to me
• new features and improvements: feel free to talk about it to me in my discord server 😉
  • Volume increment: simple, cool
  • High volume: I don't understand the use of this
  • Improved config: thanks!
  • Improved volume display: as I said, improve lang file but never directly in code (for text)

Thanks for the interest in my mod and for everything 😄

[naturecodevoid]

I did not know about that, but what I meant is that a music is more general than a song is. A song is, I believe, a music with lyrics, "sang" by a singer. But that's not a big deal

I guess it depends on your own interpretation of it, I don't know the definition of song but I think it's better than musics because musics is not correct grammar

[naturecodevoid]

• Update dependencies: not necessary as long as there is no major update

Thought it would be good to update to 1.18.2 (even though it is already compatible) and I don't think theres anything wrong with updating cloth config and modmenu and fabric API

• bumped version to 1.6.0: more like a 1.5.4 but if you want, next time leave it to me

Yeah, I realize now that I should've left this to you but I saw in CHANGELOG.md that X.X is for new features

• High volume: I don't understand the use of this

You can already do this in vanilla with editing options.txt, it's just for making the music louder without having to mess with the other volumes, it's disabled by default

• Improved volume display: as I said, improve lang file but never directly in code (for text)

As I said earlier, I tried adding it to the lang file but it broke the whole thing, this is the best solution I found

Thanks for the interest in my mod and for everything 😄

Always happy to help, this is a great mod and it definitely deserves more popularity

[naturecodevoid]

My only suggestions for future features are song controls while in the main menu and (this is a little out of scope) maybe a queue/playlist gui?

[naturecodevoid]

I believe everything you reviewed has been fixed, is there anything else?

[charlyb01]

My only suggestions for future features are song controls while in the main menu and (this is a little out of scope) maybe a queue/playlist gui?

For the main menu, I don't plan on doing anything as controls can't be used there. To me, it's out of scope. However, if you have ideas of integration, feel free to add them. For the GUI, it's definitely coming in the future. I can't tell when as I don't have much time and I was working on somehting else for the mod, but yes 😉

[charlyb01]

Would be appreciated before I merge:

• Remove all the useless stuff you added, keep only the changes that add features. No need for the refacto, the dependency update, and the song renaming.
• Keep a clean history of those changes with the following (I believe this is the way):
  • git checkout my-pull-request-branch
  • git rebase -i HEAD~n, where n is the number of last commits you want to include in interactive rebase.
  • See what you can do with it (it's explained when using the command, inside your text editor. Ask for help on discord if needed)
  • Save and exit.
  • git push --force

[naturecodevoid]

I’ll do that when I have time, you can just do a squash merge I believe, it will merge all my commits into one so they don’t effect the history

[naturecodevoid]

I don’t see the harm in updating dependencies and removing the grammar fixes, is there any reason?

[naturecodevoid]

@charlyb01 I've removed all the unnecessary changes except dependency updates and grammar fixes and made some additional improvements to the added features, is it ready for merge?

[charlyb01]

It looks like you haven't understood what I've asked for. When I will have more time, I will add your changes by myself (not via your commits) and mention you because your pull request is not okay to me. You still can use your version for yourself by building it locally if you want. I may take the time to do it next week. Thank you for your contribution!