New features and improvements

sf-inc / music_control

More control over Minecraft musics!

https://modrinth.com/mod/music-control

MIT License

6 stars 6 forks source link

New features and improvements #23

Closed amsam0 closed 2 years ago

amsam0 commented 2 years ago

Differences from previous PR:

revert dependency updates to ensure the development environment is vulnerable to log4j vulnerability
remove grammar fixes - If you look at popular music platforms such as spotify, they clearly say "Previous song" even though many of their songs do not have vocals. "musics" is definitely incorrect grammar but I've removed all changes to the language files except the tooltips, new options and volume%.

Additions:

Added volume increment feature
Added feature that allows user to increment the music volume up to 200% (disabled by default)
Improved config: added categories and tooltips
Improved volume display by adding percent symbol to the end of the displayed text

EGOIST1372 commented 2 years ago

@charlyb01 any update for the state of this PR? Also any news on 1.19?

charlyb01 commented 2 years ago

I will merge it this week with 1.19 release. I still need to tweak this PR code as there was a misunderstanding about a few things, nothing much important. Sorry for the late merge and 1.19 release, quite busy aside Minecraft modding

EGOIST1372 commented 2 years ago

It's all cool. Take your time. No hurries

On Sun, Jun 26, 2022, 21:47 charlyb01 @.***> wrote:

I will merge it this week with 1.19 release. I still need to tweak this PR code as there was a misunderstanding about a few things, nothing much important. Sorry for the late merge and 1.19 release, quite busy aside Minecraft modding

— Reply to this email directly, view it on GitHub https://github.com/sf-inc/music_control/pull/23#issuecomment-1166592453, or unsubscribe https://github.com/notifications/unsubscribe-auth/AUULT62FOXFL7D2MEMXIJ43VRCGCHANCNFSM5WTOJNAA . You are receiving this because you commented.Message ID: @.***>