search

sf-inc / music_control

More control over Minecraft musics!
https://modrinth.com/mod/music-control
MIT License
6 stars 6 forks source link

Migrate the version to 1.19.4, add Chinese translation, add filters for musics and events #32

Closed BillStark001 closed 1 year ago

charlyb01 commented 1 year ago

Hello! Thank you for your hard work, I will take the time to review it on Saturday. I took a quick look and it seems you added awesome things. I may ask for some changes though. Have a nice week =)

BillStark001 commented 1 year ago

Thanks for the reply! I will take time tomorrow or next Monday to fix what you pointed out. I also added some comments for some of your requests.

Besides, I allowed edits by maintainers, so you can directly add changes if necessary :D

charlyb01 commented 1 year ago

Alright, I may take some time to do the edits today, I will see. Thanks for your time!

charlyb01 commented 1 year ago

I'm on it! 😉

charlyb01 commented 1 year ago

There are still some work to do. I may add it tomorrow. It's just the configuration I asked you to add.

charlyb01 commented 1 year ago

Crap I typed wrong git command, now I don't have access anymore to your repo ^^ I still have the changes don't worry, I may have to do another PR