Closed BillStark001 closed 9 months ago
Hello and thank you for your new PR! =)
I will do a proper review later, but I can already ask you to split your changes in different commits in order to make it easier to read and keep a clean git history.
OMG! Sorry, I just got overwhelmed by my study and work and I didn't see your reply until now... I have already given you access to change I think :D Besides, I am not really familiar to editing commit history. If you can help me on it (like what command should I use) maybe I can find time to help to improve my commit.
Basically, the command to know is git rebase -i HEAD~n
, where you replace n by the number of commit you made. The -i
option allows you to interactively rebase: this will open your configured editor for git (you can change it if you don't like the default one) and print you your n last commits prefixed with tags.
You can find more details on the net but here is an over simplified example:
I can help you with that if you're not familiar with it. I'll see whenever I have time
Well once again I've made a mistake, my bad. Next time please don't do your changes on the main branch, but on a dedicated branch, this will avoid me doing another mistake =D
Will merge it on master directly so
Now the mod fetches the biome name from official language files