search

sf-inc / music_control

More control over Minecraft musics!
https://modrinth.com/mod/music-control
MIT License
6 stars 6 forks source link

Changig music so fast #4

Closed barraIhsan closed 3 years ago

barraIhsan commented 3 years ago

So, when BEFORE i enter my world I turn my music to 0% then I enter the world. Suddenly it says changing the music (BUT ITS REALLY FAST) its also cause performance issue Screenshot : image Video :

https://user-images.githubusercontent.com/57800056/113363196-75686080-937a-11eb-8a88-26aa58fe92d0.mp4

charlyb01 commented 3 years ago

What do you mean "but it's really fast"? When you spam click to change music? I'll check this this weekend (as your other issue)

barraIhsan commented 3 years ago

No i didnt press any key. I just joined with music turned off and suddenly like that

charlyb01 commented 3 years ago

What other mods installed do you have?

barraIhsan commented 3 years ago

image Its a lot... But i think I have tried using only this mod, and the bug still appear

charlyb01 commented 3 years ago

So yeah, this is definitely not coming from my mod: neither the performance issue, nor the spam click without touching key. I will check some of the mods you installed. There are only two possible explanations: another mod is doing something weird, or you have a keyboard issue (like it's pressing keys by itself). Also, you should check if there are no mods using the same keybind as my mod, which could be the source of lag if your keyboard press keys without your permission.

charlyb01 commented 3 years ago

Maybe try without TooManyBinds, or change my mod keybinds.... I don't know what's your problem but if you have only my mod you shouldn't have this problem (and I've tried my mods with 100+ mods and I never got any problem for my mod). Tell me if you still have this problem with what I said to try

barraIhsan commented 3 years ago

Maybe try without TooManyBinds, or change my mod keybinds.... I don't know what's your problem but if you have only my mod you shouldn't have this problem (and I've tried my mods with 100+ mods and I never got any problem for my mod). Tell me if you still have this problem with what I said to try

I think it try with only this mod, and still happened. Wait I think you didn't understand how to reproduce it

  1. Save & Quit (If you are in singleplayer)
  2. Change the Music to 0% in Options > Music & Sounds
  3. Enter the world
  4. Bug happened
charlyb01 commented 3 years ago

You keep saying "I think" as if you didn't try again while I asked you to... Because I did try everything you said and the bug never happened. When you set the music to 0% it doesn't change anything, you still can change music with keybinds but you won't hear it. If you see that it changes a lot of times music, it means that the keybind is pressed so it's either your keyboard, or another mod that do some weird thing (maybe with keybinds), as I already told you

barraIhsan commented 3 years ago

image Ok, so this is my .minecraft/mods folder (with some folder inside that is for mods that unused). And its still like the video I sent in image This is my Music and sounds setting So when I change the master volume to like 1% it not gonna change the music so fast BUT when I change it again to 0% the bug appears again. Is there the fabric API is outdated, or the music control outdated.

charlyb01 commented 3 years ago

Alllllright, with this configuration the mod tries to play music while the master is off. And it spams every tick because I guess you changed the default config so that there is no time without music, am I right? Thanks for your patience. I'll see what I can do, I guess next week I'll publish a version that fix it and that add possibility to play custom musics ;) If it's not out out next week, don't worry I won't forget you

barraIhsan commented 3 years ago

ok, thanks!