search

sf-inc / music_control

More control over Minecraft musics!
https://modrinth.com/mod/music-control
MIT License
6 stars 6 forks source link

Add mute feature [request] #46

Closed Qsta981 closed 2 months ago

Qsta981 commented 8 months ago

It would be nice if I could just mute music with one button press. Maybe add a keybind to mute and unmute music.

charlyb01 commented 8 months ago

Hello! You can already in/decrease the volume with keybinds, or pause the music.
But I guess it's a bit different, as you can't pause if there is no music playing. I guess I could just enhance the pause keybind, what do you think?

charlyb01 commented 7 months ago

I released a new version that pause the music player when not playing music, so that if no music is playing, it won't play music later, as you would expect for a mute. Don't hesitate to try it out and tell me if that's enough in your opinion!

Anoaxx commented 7 months ago

maybe immidite mute would be a cool addition? :3

charlyb01 commented 7 months ago

Immediate mute? Doesn't pausing music immediately "mute" the music? What do you mean exactly?

charlyb01 commented 3 months ago

Hi again! Please let me know if current features are not sufficient for this request.

Qsta981 commented 3 months ago

Sorry for accidentally closing it, but correct me if I am wrong, but I think music in the title menus still plays even when paused. It would be nice if there was a mute button just like on a computer.

charlyb01 commented 3 months ago

If the title menus, you don't have access to keybinds, so you can't pause the music. However, if you pause the music in-game and go back to the title menus, music won't play again.

However, the purpose of the mod is to control how music is played in-game. I don't plan to add things in the title menus to control the music, even though I keep this idea on a sidenote as mentioned in #21. If that's the only thing missing from this issue, I will close it as I consider it out of scope of the mod, and I already keep one issue opened for title menu controls.