search

sf-inc / music_control

More control over Minecraft musics!
https://modrinth.com/mod/music-control
MIT License
6 stars 6 forks source link

Port to 1.20.4 & refine Chinese & Japanese translations #49

Closed BillStark001 closed 9 months ago

BillStark001 commented 9 months ago

Hi there. I've updated the mod to newest version and updated the language files. Hope this time the commit history meets your requirement :D

charlyb01 commented 9 months ago

Hello! Thank you for your contribution, the history looks great. I will take a better look at it tomorrow and merge it =D

BillStark001 commented 9 months ago

Wait, I found something very weird. After loading the mod into the game, I found some of the C418 musics are unable to play and the settings panel looks like this: screenshot The following is the full log: log_1204.txt Since I cannot reproduce this issue in the development environment, I'm not sure what to do. It maybe some mods or Minecraft itself changed the resource keys, but I've found no changelogs on the Wiki. I'll take time to investigate on this issue afterwards.

charlyb01 commented 9 months ago

I will take a look tomorrow. I'm pretty sure they just renamed the c418 music with their actual name instead of "creative1", "creative2", ... The change shouldn't be really hard.

BillStark001 commented 9 months ago

Ok, I found the reason. Seems Mojang did rename the keys (link), but gradle's resource file is the old one so I didn't notice it :D

charlyb01 commented 9 months ago

Thanks again for your work! =)