search

sf-inc / sihywtcamd

So I heard you were talking crap about Minecraft's difficulty ?
https://modrinth.com/mod/difficulty
MIT License
5 stars 3 forks source link

Worldgen Lock when baby tower spawning enabled #59

Closed Linguardium closed 1 month ago

Linguardium commented 3 months ago

I expect the issue is here:

https://github.com/sf-inc/sihywtcamd/blob/5dcc05be356bd3e6bf741b0287723b1f13f61fe4/src/main/java/com/github/galatynf/sihywtcamd/mixin/zombie/ZombieLivingMixin.java#L57

likely related to #38 crash-2024-08-25_22.58.31-server (2).txt

initialize is called on the new baby, which would trigger a potential mounting of a chicken, which could cause the same dismount code. ideally you should pass a ZombieEntity.ZombieData. no need to set the baby state as its set via the entitydata you feed in

charlyb01 commented 3 months ago

Hi, thanks for the report! You're totally right, I'm doing a safety check for the first baby zombie only, but the other ones can also try to mount chickens first. I will pass a ZombieData as you suggest, this seems to be the perfect fix

charlyb01 commented 3 months ago

(and thanks for reporting the malicious link, I reported it to Github)