search

sf-inc / xp_storage

A mod that lets you store your experience in multiple ways!
https://modrinth.com/mod/xp-storage
MIT License
5 stars 10 forks source link

Level-Up Sound Plays on New Recipe #25

Closed Foundedd closed 1 year ago

Foundedd commented 1 year ago

Minecraft Info

Versions

Minecraft Version 1.20.1 Quilt Loader 0.20.2 xp_storage 1.5.4

mods directory

xp_storage-1.5.4+1.20.1.jar qfapi-7.3.0_qsl-6.1.2_fapi-0.89.0_mc-1.20.1.jar

Bug Description

When your level is a multiple of 5, obtaining new recipes triggers the level-up sound. (Similar to #23).

Steps to Reproduce

  1. Create a new world (with cheats enabled)
  2. Run /experience add @p 5 levels and wait for the level-up sound to finish.
  3. Gain a new recipe (e.g., get a piece of wood) - level-up sound triggers.
  4. Give yourself another level and gain a new recipe - level-up sound does not trigger.

Additional Notes

If you have the following modlist it causes the XP gain sound to be played for any inventory change (picking up an item, shift-clicking an item from your hotbar to your inventory or vice versa, etc.). I wasn't able to get this to happen with just your mod, but it still only happens at every 5 levels and the issue is resolved by removing your mod.

modlist AdditionalStructures-1.20.x-(v.4.2.1).jar Adorn-5.0.0+1.20.1-fabric.jar AirHop-v8.0.0-1.20.1-Fabric.jar AttributeFix-Fabric-1.20.1-21.0.2.jar AxesAreWeapons-1.7.1-fabric-1.19.3.jar BagOfHolding-v8.0.0-1.20.1-Fabric.jar BeaconOverhaul-1.8.4+1.20.jar BedBenefits-Fabric-1.20.1-13.0.2.jar BetterAdvancements-Fabric-1.20.1-0.3.2.161.jar BetterF3-7.0.1-Fabric-1.20.1.jar BetterTridents-v8.0.1-1.20.1-Fabric.jar BlockRunner-v8.0.0-1.20.1-Fabric.jar Bookshelf-Fabric-1.20.1-20.0.5.jar BotanyPots-Fabric-1.20.1-13.0.17.jar Clumps-fabric-1.20.1-12.0.0.3.jar Companion-1.20-fabric-5.1.0.jar Couplings-1.9.4+1.20.jar Croptopia-1.20.1-FABRIC-2.3.2.jar DetailArmorBar-2.6.3+1.20.1-fabric.jar DiagonalFences-v8.0.1-1.20.1-Fabric.jar EasyMagic-v8.0.1-1.20.1-Fabric.jar EchoChest-v8.0.0-1.20.1-Fabric.jar EnchantmentDescriptions-Fabric-1.20.1-17.0.8.jar Fastload+1.18.2-1.20-3.4.0.jar ForgeConfigAPIPort-v8.0.0-1.20.1-Fabric.jar Iceberg-1.20.1-fabric-1.1.15.jar IllagerInvasion-v8.0.2-1.20.1-Fabric.jar Incendium_1.20.1_v5.3.1.jar InventorySorter-1.9.0-1.20.jar ItemBorders-1.20.1-fabric-1.2.0.jar Item_Obliterator-Fabric_Quilt-1.4.0.jar Jankson-6.0.0+j1.2.3.jar LeavesBeGone-v8.0.0-1.20.1-Fabric.jar Modern-Dynamics-0.7.0-beta.jar MoreBeautifulButtons-fabric-1.20.1-1.5.0.jar MoreBeautifulPlates-fabric-1.20.1-1.6.0.jar MoreCullingExtra-1.1-1.20.1.jar MouseTweaks-fabric-mc1.20-2.25.jar Notes-1.20.1-2.1.0-fabric.jar Nullscape_1.20.1_v1.2.2.jar Patchouli-1.20.1-81-FABRIC.jar PickUpNotifier-v8.0.0-1.20.1-Fabric.jar Ping-Wheel-1.5.1-fabric-1.20.1.jar Prism-1.20.1-fabric-1.0.5.jar PuzzlesLib-v8.0.24-1.20.1-Fabric.jar RoughlyEnoughItems-12.0.659.jar RoughlyEnoughProfessions-fabric-1.20.1-2.0.1.jar Stoneworks-v8.0.0-1.20.1-Fabric.jar Structory_1.20.2_v1.3.3.jar Towns-and-Towers-1.11-Fabric+Forge.jar UniversalEnchants-v8.0.0-1.20.1-Fabric.jar WWOO-FABRIC+FORGE+QUILT-3.2.0-beta2.jar Wabi-Sabi-Structures-2.0.0-1.20-Fabric.jar XaerosWorldMap_1.34.1_Fabric_1.20.jar Xaeros_Minimap_23.8.2_Fabric_1.20.jar YeetusExperimentus-Fabric-2.3.1-build.6+mc1.20.1.jar YungsApi-1.20-Fabric-4.0.2.jar YungsBetterDesertTemples-1.20-Fabric-3.0.3.jar YungsBetterDungeons-1.20-Fabric-4.0.3.jar YungsBetterJungleTemples-1.20-Fabric-2.0.3.jar YungsBetterMineshafts-1.20-Fabric-4.0.4.jar YungsBetterNetherFortresses-1.20-Fabric-2.0.4.jar YungsBetterStrongholds-1.20-Fabric-4.0.3.jar YungsBetterWitchHuts-1.20-Fabric-3.0.3.jar advancementframes-1.20-2.1.0-fabric.jar adventurez-1.4.19.jar alloy-forgery-2.0.22+1.20.jar alternate-current-mc1.20-1.7.0.jar appleskin-fabric-mc1.20.1-2.5.1.jar archers_arsenal-1.0.3v201.jar architectury-9.1.12-fabric.jar artifacts-fabric-9.1.0.jar athena-fabric-1.20.1-3.1.1.jar badpackets-fabric-0.4.2.jar balm-fabric-1.20.1-7.1.4.jar bedspreads-quilt-6.2.0+1.20.1.jar better-trim-tooltips-1.0.1.jar bettermounthud-1.2.2.jar bettersafebed-fabric-1.20-9.jar biggerspongeabsorptionradius-1.20.1-3.1.jar blanket-client-tweaks-1.1.4.jar borderless-mining-1.1.8+1.20.1.jar c2me-fabric-mc1.20.1-0.2.0+alpha.11.0.jar capes-1.5.2+1.20-fabric.jar carpet-fixes-1.20-1.16.1.jar charmofundying-quilt-6.4.3+1.20.1.jar chipped-fabric-1.20.1-3.0.1.jar chunkloaders-1.2.8-fabric-mc1.20.1.jar cloth-config-11.1.106-fabric.jar collective-1.20.1-6.66.jar comforts-quilt-6.3.3+1.20.1.jar continuity-3.0.0-beta.3+1.20.1.jar coppernugget-1.20.1-0-fabric.jar creeperoverhaul-3.0.1-fabric.jar cristellib-1.1.1-quilt.jar cupboard-fabric-1.20.1-2.0.jar cursery-fabric-1.20.1-4.1.jar customizableelytra-quilt-2.1.0+1.20.jar dark-loading-screen-1.6.14.jar darksmelting-fabric-1.20.1-1.0.1.jar dawn-5.0.0.jar discerning-furnace-1.0.11+MC1.19-1.20.1.jar elytraslot-fabric-6.3.0+1.20.1.jar enchanted-vertical-slabs-1.9.1.jar enderitemod-1.5.0-1.20.1.jar entityculling-fabric-1.6.2-mc1.20.1.jar expanded-enderchest-fabric-1.1.0+1.20.1.jar explorify-v1.3.0-mc1.20u1.20.1.jar fabric-carpet-1.20-1.4.112+v230608.jar fabric-language-kotlin-1.10.10+kotlin.1.9.10.jar ferritecore-6.0.0-fabric.jar fixedanvilrepaircost-1.20.1-3.1.jar fusion-1.0.6-fabric-mc1.20.jar gamemenuremovegfarb-fabric-mc1.19.4-2.1.2.jar geckolib-fabric-1.20.1-4.2.3.jar graves-3.0.0+1.20.1.jar guardvillagers-2.0.8-1.20.1.jar handcrafted-fabric-1.20.1-3.0.1.jar highlight-fabric-1.20-2.0.1.jar improvedsigns-1.3.1.jar indium-1.0.27+mc1.20.1.jar iris-mc1.20.1-1.6.9.jar ironchests-5.0.2-fabric.jar jamlib-0.6.1+1.20.x.jar jeed-1.20-2.1.5-fabric.jar justhammers-fabric-2.0.0+mc1.20.1.jar lazydfu-0.1.3.jar letmedespawn-fabric-1.20-1.1.0.jar lithium-fabric-mc1.20.1-0.11.2.jar logprot-fabric-1.20.1-3.1.jar lootintegrations-fabric-1.20.1-3.2.jar lovely_snails-1.1.3+1.20.1.jar mcw-bridges-2.1.0-mc1.20.1fabric.jar mcw-doors-1.1.0fabric-mc1.20.1.jar mcw-fences-1.0.7-mc1.20.1fabric.jar mcw-furniture-3.2.0b-mc1.20.1fabric.jar mcw-lights-1.0.6-mc1.20.1fabric.jar mcw-paths-1.0.3fabric-mc1.20.1.jar mcw-roofs-2.2.4-mc1.20.1fabric.jar mcw-trapdoors-1.1.1-mc1.20.1fabric.jar mcw-windows-2.2.0-mc1.20.1fabric.jar memoryleakfix-fabric-1.17+-1.1.2.jar modernfix-fabric-5.7.5+mc1.20.1.jar modmenu-7.2.2.jar moonlight-1.20-2.8.35-fabric.jar moreculling-1.20.1-0.19.0.jar mru-0.2.1+1.20.jar mythicupgrades-mc1.20.1-2.2.2.jar netherportalfix-fabric-1.20-13.0.0.jar no-telemetry-1.7.0.jar owo-lib-0.11.2+1.20.jar polymorph-quilt-0.49.0+1.20.1.jar qfapi-7.3.0_qsl-6.1.2_fapi-0.89.0_mc-1.20.1.jar rechiseled-1.1.4a-fabric-mc1.20.jar reeses_sodium_options-1.6.5+mc1.20.1-build.95.jar reinforced-barrels-2.4.1+1.20.jar reinforced-chests-2.4.2+1.20.jar reinforced-shulker-boxes-2.5.0+1.20.jar rer-2.9.0.jar resourcefulconfig-fabric-1.20.1-2.1.0.jar resourcefullib-fabric-1.20.1-2.1.11.jar right-click-harvest-3.2.3+1.19.x-1.20.1-fabric.jar simplylight-fabric-1.20.1-1.4.5.jar sodium-extra-0.5.1+mc1.20.1-build.112.jar sodium-fabric-mc1.20.1-0.5.3.jar starlight-1.1.2+fabric.dbc156f.jar status-effect-bars-1.0.3.jar supermartijn642configlib-1.1.8-fabric-mc1.20.jar supermartijn642corelib-1.1.13-fabric-mc1.20.jar supplementaries-1.20-2.6.3-fabric.jar transmog-quilt-1.2.4+1.20.jar trashcans-1.0.18-fabric-mc1.20.jar trashslot-fabric-1.20-15.1.0.jar travelers-backpack-1.20.1-9.1.6.jar trimeffects-1.0.1-fabric.jar trinkets-3.7.1.jar triqueapi-mc1.20.1-1.1.0.jar twigs-3.1.0-fabric.jar universal_ores-1.5.2.jar vanilla_degus-1.20.x-v1.5.0-fabric.jar veinmining-quilt-1.2.0+1.20.1.jar weakerspiderwebs-1.20.1-3.2.jar wildlife-1.20.1-2.2.jar woof-4.0.2+1.20.1.jar worldedit-mod-7.2.15.jar wraith-waystones-3.1.3+mc1.20.jar wso16-fabric-1.2.jar wthit-quilt-8.4.0.jar xp_storage-1.5.4+1.20.1.jar
charlyb01 commented 1 year ago

Hello and thank you for the report. This issue was already reported in the issue you mentioned.
I will fix this in a coming update. Please refer to the first issue if you want to follow up the state of the issue 😉