search

sf-interns / mathswipe

A game with numbers
https://sf-interns.github.io/mathswipe
MIT License
3 stars 1 forks source link

Add twitter share button #78

Closed bmwwoo closed 9 years ago

ericthewry commented 9 years ago

Well want to incorporate this into https://github.com/sf-interns/mathswipe/pull/73

Not necessary now, but well want to do that in the future.

LGTM

ericthewry commented 9 years ago

Actually, wait, I take that back. We should call this TwitterShareService or something in case we want to include other social media. Then ShareGameService would manage all of the social media.

I think we should keep ShareGameService and then TwitterShareService managed by it. Then we'll also have FacebookShareService and TumblrShareService or whatever else (not for this PR), and ShareGameService will do whatever initializing and location management needs doing.

ericthewry commented 9 years ago

LGTM :ship: