sfPlayer1 / Matcher

Tool for tracking elements in obfuscated Java archives across releases
GNU General Public License v3.0
75 stars 41 forks source link

Mappings of members of inner classes are not saved #11

Open natanfudge opened 5 years ago

natanfudge commented 5 years ago

plz fix.

NebelNidas commented 1 year ago

I can still reproduce this issue on the latest commit. Will need to check what's going on there

NebelNidas commented 1 year ago

It happens because the mapped name equals the original name: https://github.com/sfPlayer1/Matcher/blob/f01ed5a7813458abb55a254625e3c4ad48c16590/src/matcher/mapping/Mappings.java#L805

@sfPlayer1 Not sure if that's intended behavior? If yes, this issue can be closed. Then we would need to adjust the other mapping tools though

Edit: Perhaps it'd be best to add a checkbox disabling this behavior to the mappings export dialog?