sfPlayer1 / Matcher

Tool for tracking elements in obfuscated Java archives across releases
GNU General Public License v3.0
75 stars 41 forks source link

Support javadocs in the Enigma format #13

Closed natanfudge closed 4 years ago

natanfudge commented 4 years ago

Looking at EnigmaImpl, Matcher would throw when it encounters a JAVADOC (COMMENT, as liach is now saying) line, which Enigma would output following FabricMC/Enigma#185. It needs to parse and write it properly.

natanfudge commented 4 years ago

Here's an example mapping file for testing (it is very reminiscent of V2)

CLASS net/minecraft/class_744 net/minecraft/client/input/Input
    COMMENT This is a class javadoc
    FIELD field_3903 sneaking Z
    FIELD field_3904 jumping Z
    FIELD field_3905 movementForward F
    FIELD field_3906 pressingRight Z
    FIELD field_3907 movementSideways F
        COMMENT This is a field javadoc
    FIELD field_3908 pressingLeft Z
    FIELD field_3909 pressingBack Z
    FIELD field_3910 pressingForward Z
    METHOD method_20622 hasForwardMovement ()Z
    METHOD method_3128 getMovementInput ()Lnet/minecraft/class_241;
    METHOD method_3129 tick (Z)V
        COMMENT This is a method javadoc
        ARG 1 boolean_1
            COMMENT This is a parameter javadoc
sfPlayer1 commented 4 years ago

This should be fully implemented now