search

sfPlayer1 / Matcher

Tool for tracking elements in obfuscated Java archives across releases
GNU General Public License v3.0
75 stars 41 forks source link

Theme support #20

Closed NebelNidas closed 1 year ago

NebelNidas commented 1 year ago

Adds basic theming support, more syntax highlighting and three new themes:

Here are some screenshots:

VS Code Light ![image](https://user-images.githubusercontent.com/48808497/200183020-bcb22ac8-a3cf-4601-9b70-e949f1f2d826.png)
One Dark (with diff colors enabled) ![image](https://user-images.githubusercontent.com/48808497/200183027-6cd68f24-5ad4-492a-8b5a-5a4bdac34318.png)
Darcula ![image](https://user-images.githubusercontent.com/48808497/200183032-f1be5467-f47e-495b-966d-7d11e880cdd5.png)

Also now passes each ViewChange event a reason as to why it's been triggered, so UI elements can be updated selectively (improves performance).

Depends on #18 and #19.

NebelNidas commented 1 year ago

I think this is ready for review now. Of course, there are always more things one can add, like theming for popup-dialogs or more syntax highlighting, but then this PR would never get finished. I'd rather do a follow-up PR later with additional stuff :)

The only thing I'm not sure about yet is if all onViewChange events still fire correctly. From my testing, they mostly do, but we may need an additional match change event since sometimes the colors don't update correctly - will need to investigate further though