Additional improvements to implement a test using testcontainers (https://testcontainers.com/) have been taken:
basic setup with gradle
ant is still used to build the artifacts
the tests using testcontainers can only be run with gradle
a test to verify that the issue was actually resolved (revert the change in the first commit to see the test fail)
the test starts an mssql server instance using testcontainers
a minimal script is provided in order to setup the database to reproduce the issue
the test also asserts certain properties in the archive - not only if the archive process was successfull
In order to implement the test in a dedicated package, some changes had to be made
the constructor SiardFromDb was made public
the method getReturn() in SiardFromDb was made public
All files affected by these changes where reformatted using the Intellij IDEA code style and unnecessary comments (e.g. structural comments, chapter comments, wrong comments) where removed. Typos in comments and string litarals where also fixed.
this MR provides a fix for #25
The actual fix is just the change contained in: https://github.com/sfa-siard/SiardCmd/commit/26447ddd83593fbb166b6e8b712b1ae5ec3b64c4
Additional improvements to implement a test using testcontainers (https://testcontainers.com/) have been taken:
In order to implement the test in a dedicated package, some changes had to be made
SiardFromDbwas made publicgetReturn()in SiardFromDb was made publicAll files affected by these changes where reformatted using the Intellij IDEA code style and unnecessary comments (e.g. structural comments, chapter comments, wrong comments) where removed. Typos in comments and string litarals where also fixed.