sfa-siard / SiardCmd

SIARD Suite - SiardCmd
Other
9 stars 5 forks source link

Feature/integration tests with testcontainers #28

Closed sdbuehlmann closed 1 year ago

sdbuehlmann commented 1 year ago
sdbuehlmann commented 1 year ago

Dear @mburri, thanks for your valuable feedback. I've implemented all of your inputs except one: I've never deleted the doc-directory. I've deleted the target-directory, which, as far as I know, is a build-output-directory containing just temporary files. There were just duplicated files in it, so I thought that it should be okay to delete it.

Could you please review the PR again?

Please note the following things: