search

sfackler / r2d2

A generic connection pool for Rust
Apache License 2.0
1.51k stars 82 forks source link

Examples needed #89

Closed dataf3l closed 5 years ago

dataf3l commented 5 years ago

It would be nice if the documentation had examples on how to create mysql, postgres and sqlite connection pools, since the "FooDB" doesn't exist.

sfackler commented 5 years ago

https://github.com/outersky/r2d2-mysql#example https://github.com/sfackler/r2d2-postgres#example https://docs.rs/r2d2_sqlite/0.11.0/r2d2_sqlite/#example

dataf3l commented 5 years ago

Thank you for providing these examples!, this is exactly what I needed!, does in your opinion makes sense to add them to the readme or the rustdoc, so that people can find them with relative ease?

sfackler commented 5 years ago

I don't think it would make sense to have hundreds of lines of examples for 10+ databases in this crates README.

dataf3l commented 5 years ago

I understand. How do you feel about a repo with examples, and a link in the docs to said repo? Also, may I know the names of the 10 DBs ?

sfackler commented 5 years ago

They are listed in the README: https://github.com/sfackler/r2d2#r2d2

dataf3l commented 5 years ago

So I'll just assume this means, no changes will be made.

I understand.