search

sfackler / rust-openssl

OpenSSL bindings for Rust
1.4k stars 752 forks source link

Don't leave errors on the stack in `MdCtxRef::digest_verify_final` #2283

Closed alex closed 2 months ago

alex commented 2 months ago

@sfackler let me know if you think this should just ignore teh errors, I'm not sure if Ok(false) ever actually occurs.

botovq commented 2 months ago

Ok(false) can happen: 1 signature is valid, 0 signature is invalid (typically no error on the stack), < 0 a library error occurred (typically error on the stack).

sfackler commented 2 months ago

This seems right to me. Must have been another example of a function where the return value docs used to be more specific.