Closed nyurik closed 4 months ago
I'm not super opposed to this, but at the same time I'm not sure it'll make a huge difference. What portion of runtime is spent constructing config?
@sfackler config specifically is not that big of a deal of course. My concern is that any frequently used code teaches users on how to do things - and in this case, IMO, the API should have only allowed String
as the parameter, but because breaking API is not worth it, might as well introduce a backwards compatible solution.
Reasoning:
P.S. community recommended using explicit generic rather than impl Into<String>
as a param type.
Using
impl Into<String>
instead of&str
in a fn arg allows both&str
andString
as parameters - thus if the caller already has a String object that it doesn't need, it can pass it in without extra cloning.The same might be done with the password, but may require closer look.