Open allan2 opened 4 weeks ago
When constructing time types using out-of-range values, panic occurs. This affects most of the FromSql and ToSql implementations for time 0.2 and 0.3.
time
FromSql
ToSql
let row = client.query_one("SELECT 'infinity'::timestamp", &[])?; let res = row.try_get::<_, time::PrimitiveDateTime>(0); // this panics
Minimal example here --> allan2/postrgres-time-overflow
The fix is to use fallible operations like checked_add and try_from. An infinity test like test_special_params_without_wrapper should also be added for time. [1].
checked_add
try_from
test_special_params_without_wrapper
I have a PR in the works but I will wait for #1164 and #1170 first.
When constructing
time
types using out-of-range values, panic occurs. This affects most of theFromSql
andToSql
implementations fortime
0.2 and 0.3.Minimal example here --> allan2/postrgres-time-overflow
The fix is to use fallible operations like
checked_add
andtry_from
. An infinity test liketest_special_params_without_wrapper
should also be added fortime
. [1].I have a PR in the works but I will wait for #1164 and #1170 first.