sfackler / rust-postgres

Native PostgreSQL driver for the Rust programming language
Apache License 2.0
3.49k stars 443 forks source link

Add text format result support #961

Open ZENOTME opened 2 years ago

ZENOTME commented 2 years ago

What this PR do

This PR add the TEXT format support for query result. In addition, this modification is compatitable for previous version. User needn't to change the original query.

Context

The rust-postgres only support binary format query result in extended query mode before. But in some cases, binary format of some type(such as multidimensional list) isn't support well. Sometimes, TEXT format result is more convenient. Such as in sqllogictest(It is a testing framework to verify the correctness of an SQL database), it can test a database using extended query protocol. In this case, TEXT format is more convenient to compare the actual result with the expect result.

I try to support text format in this PR. To make it compatible with the previous version, I add a result_format flag in client. The query will send message according to the result_format. And add the get_text in row to get the result as TEXT format.

Some problem may need to solved

Anyway, I'm glad to make any modification and hope it can be merged into main version.

related issue: #882

tobyhede commented 11 months ago

+1 from me - our use case needs to support the text format.