search

sfackler / rust-postgres

Native PostgreSQL driver for the Rust programming language
Apache License 2.0
3.49k stars 443 forks source link

Merge whole history of tokio-postgres-rustls as a crate #962

Open nyurik opened 2 years ago

nyurik commented 2 years ago

This code does not have any significant changes from the original (archived) code at https://github.com/jbg/tokio-postgres-rustls

Changes:

TODO:

See also #421

jbg commented 2 years ago

FYI that repo is only archived because it moved to SourceHut. The crate is still developed and maintained. That being said, I'm happy if it can come under the rust-postgres umbrella.

nyurik commented 2 years ago

@jbg thank you so much! I wasn't sure what has happened to it, and some of us got really concerned when we saw that your repo was archived without any notes, while crates.io still pointed to it. Could you maybe unarchive it, put some big notification at the top with the links to the new location, and re-archive it?

I am not familiar with the sourcehut, and I tried to find it there, but it didn't come up with any results.

I am all for collaborative software development -- we tend to support software until our interest runs out, so ideally there should be a community behind each project rather than a single person - to prevent any kind of disaster or lack of interest from ruining an amazing project. I am not sure what @sfackler 's plans are for this project - I really hope we can all work on it together, perhaps starting an organization too? Regardless, you have done a great job maintaining it, so I wouldn't want to take it away from you, but please consider keeping it on github so that all other FOSS devs can easily participate.

Thanks!

jbg commented 2 years ago

There is a link at the top of the Github repo (at the right on desktop) to the Sourcehut repo.

I may just move back to Github given that hosting elsewhere causes this confusion 😬

sfackler commented 1 year ago

Sorry for the delay - if @jbg's happy maintaining it externally then I think it'd probably be best to keep things as-is.

nyurik commented 1 year ago

I'm ok either way, but one thing to note: we urgently need to implement all the tls compatibility with rustls - the upstream team seems to not want to have an easy path for us to upgrade from openssl to rustls, and thus we would have to do a considerable implementation of everything related to sqlmode=....

I think it would be best to implement this type of functionality in this project for higher visibility -- keeping postgresql-related things together is easier than trying to hunt for individual pieces. Of course if @jbg is ok with this transition?

jbg commented 1 year ago

@nyurik Can you clarify what functionality you are talking about when you say "all the tls compatibility with rustls"? Any kind of verification (or lack thereof) that you can implement with rustls, you can use tokio-postgres-rustls with. There is no need for any special support to be implemented in tokio-postgres-rustls or tokio-postgres, you just pass the appropriate ClientConfig to MakeRustlsConnect::new(). If you're having a specific problem, please open a related issue.

jbg commented 1 year ago

Ah, I see you already have. Linking to https://github.com/jbg/tokio-postgres-rustls/issues/11 here for context and will continue the discussion there.

serprex commented 10 months ago

Given the lack of response to any of

vasilakisfil commented 10 months ago

I really think that tokio-postgres-rustls should be part of this repo, even if not maintained by @sfackler.

jbg commented 9 months ago

I've made a tokio-postgres-rustls release (apologies for the delay -- was moving countries!).