Type property "regions" missing for type Holiday

sfakir / feiertagejs

Feiertage.js is a small npm module to calculate German holidays for each Bundesland

MIT License

61 stars 10 forks source link

Open chrschae opened 5 months ago

chrschae commented 5 months ago

Hey,

I just want to remark that the property "regions" seems to be missing for the type Holiday.

In my case i noticed it when using const holiday = getHolidaysByDate(date,region) that the property "regions" is missing.

sfakir commented 2 months ago

Hi @chrschae , I reviewed your case and added unittest in this commit to reproduce the situation:

Basically the property "regions" is set for the holiday type. Could you give me some more information - maybe the specific holiday?

Please note: if there is no holiday found the response would be void, and then regions is not available.

Hope this helps.