sfalkman / ngenic-hass-platform

Ngenic platform for Home Assistant
MIT License
33 stars 18 forks source link

HACS compatibility #9

Closed JohNan closed 4 years ago

JohNan commented 4 years ago

Hi,

I tried adding this repository to HACS but it is not compatible. I would really appreciate if you could add support for it. It makes it a lot easier to add to Home Assistant and to keep updated. You can find the instructions on this page https://hacs.xyz/docs/publish/integration

sfalkman commented 4 years ago

Good idea! I haven't used HACS, so I'll install it and modify the component to work with it as soon as I got the time.

Basically, it looks like I only need to move the code to custom_components/ngenic/ and add an info.md in the root

JohNan commented 4 years ago

Thanks! Yes, it's really easy to get it working. HACS is really neat. Makes so much easier to add and update third-party integrations.

I was thinking about making a PR, we'll see who's first 😁

sfalkman commented 4 years ago

Too slow :) Try it out now

JohNan commented 4 years ago

It works perfectly! Thank you!

patrik3k commented 4 years ago

Yes works lika a charm! Very well done. Is it possible to add it to the normal HACS integration directory. I added it with a Custom repository now.