sfall-team / sfall

sfall - Engine modifications for Fallout 2
https://sfall-team.github.io/sfall/
GNU General Public License v3.0
348 stars 41 forks source link

load save error #425

Closed nirran closed 2 years ago

nirran commented 2 years ago

when loading this save vic is removed from party,tho i am at 3 members(and have 10 charisma),if u load the save,then go north to the crop fields map,save the game then load it,vic is removed from party,i tried to narrow what version causes it unfortunatly i went back to vrs 3.0 and same,i think it has to do with cur_map_index out of bounds,as map is num 257,tho it doesnt happen on other higher maps,this data folder is my current aned has the save in it,my master.dat is megamod vrs 2.47.6,tried with megamod vic script and vanilla vic script,also tired w/o any of my sfall scripts https://www.mediafire.com/file/qmlnkghjakxj63z/Fallout_2.zip/file

edit : i have played with this save severaL lvls,vic didnt error,only on that specific map edit2 : i am loath to create more issues,but with 4.3.3 this save(with above settup) ,when party members reload weapon the game crashes,does not crash with 4.3.2,to reprocude,load save and go downstairs,combat untill party member loads weap,thats it SLOT07.zip

nirran commented 2 years ago

i belive the second issue is above post is similar to this

https://www.nma-fallout.com/threads/crash-when-in-combat-in-new-reno-5-mods-in-description.220956/

edit : edit posts here or reply new?

NovaRain commented 2 years ago

The point of the crash is related to when the engine tried to get the name of an object. I cannot reproduce the crash on my basic UP/RP games, but I did get some random issues that the message doesn't show the correct item but the one in my/critter's active slots in various occasions, seems like the engine taking wrong object pointer or something.

Some examples:

So far I couldn't find a way to reproduce the errors reliably.

nirran commented 2 years ago

the reload thing happens always for me,maybe that cna help?

FakelsHub commented 2 years ago

https://www.nma-fallout.com/threads/crash-when-in-combat-in-new-reno-5-mods-in-description.220956/

https://github.com/FakelsHub/sFall-X/commit/e3618a38f62b4dbf5a49e457623ab08724262083 this fix seems to solve this problem.

FakelsHub commented 2 years ago

The message from @nirran is as usual difficult to read for me. the meaning of what was written is unclear because of his clumsy style of writing.

NovaRain commented 2 years ago

@nirran You can try the newest develop build to see if it fixes the second issue (crash in combat).

@FakelsHub Maybe later you could look into the weird issue of incorrect item names I ran into? I don't use EXTRA_WIN_MSG_CHECKS and it doesn't crash, and I had the same issue with both base and ext builds.

nirran commented 2 years ago

sorry FakelsHub,ill try to be clear in the future,and yes nova the party members dont crash fo2 when they reload with the test build\

FakelsHub commented 2 years ago

Maybe later you could look

I can't get this behavior.

NovaRain commented 2 years ago

Maybe later you could look

I can't get this behavior.

It's a rather random occurrence. I first noticed the behavior when I was testing set_self and drop_obj (print what item is dropped from me), then when checking the save in RPU's issue 131 it's more noticeable.

For me the incorrect "use X item on NPC" message is often (not always) displayed after I close my inventory and use items (drugs, food, etc.) on NPCs. Maybe following these steps:

  1. Load a saved game, and put some items in both hand slots.
  2. Use an item on the party member.
  3. Open the inventory then close it.
  4. Repeat step 2, see the message.
FakelsHub commented 2 years ago

Maybe following these steps:

nothing

NovaRain commented 2 years ago

Maybe following these steps:

nothing

Here's the video I reproduce the issue: incorrect message on item use It seems the main triggers are "after opening/closing the inventory" and "using the same item".

FakelsHub commented 2 years ago

OK now I see the sequence. 100% reproduce.

NovaRain commented 2 years ago

OK now I see the sequence. 100% reproduce.

Looks like it's due to some change in 4.3.1, with 4.3.0.2 there's no such issue.

nirran commented 2 years ago

this isnt fixed,i used a script that unloads all items with ammo in dudes inven and it said 'unloaded your bug" bug has a script attached that does lots of stuff,bug is vanilla bug item

thsi si the script GL_Auto_Loot.zip

NovaRain commented 2 years ago

You just dropped a source code that I can't compile (guess it's for megamod). And where should I get the config file? From your autoloot mod? If you don't like to give proper details, then don't except much response from me.

nirran commented 2 years ago

sorry dude,forgot the headers and i was mistaken anyway,i didnt have the correct sfall installed,disregard,bug seems to be with previous sfall