search

sfbrigade / adopt-a-drain

A web application that allows citizens to "adopt" a storm drain in San Francisco. In use, and in development at other brigades. Looking for a maintainer or someone interested in developing further in collaboration with others across the country.
http://adoptadrain.sfwater.org/
BSD 3-Clause "New" or "Revised" License
44 stars 57 forks source link

Address Search Function Not Working #360

Open FrankieBurton opened 5 years ago

FrankieBurton commented 5 years ago

Hi there,

Idil and I are both having issues using the address search function for https://adoptadrain.sfwater.org/. When we search nothing happens at all for many addresses (see image below). Please help since this is one of the main features of the app!

image

Thanks!

jszwedko commented 5 years ago

@FrankieBurton thanks for reporting this! That is a pretty big bug.

I'm pretty sure this happened due to the change in licensing terms of Google Maps recently; they no longer allow unauthenticated requests. If this is true, this has probably been broken for at least a few weeks.

I've went ahead and created a Google API key for the Geocoding API (which the search uses) and configured the application to use it. The limit on the key for free usage is 5000 requests per 100 seconds which I think should be suitable for the amount of traffic we see. It would be good for another person to have access to these credentials in case I am unavailable. Is there anyone at the PUC that might be a good candidate for that?

I would have expected this to show up in the error reporting, which would have alerted us. I dug around a little bit, but I'm not immediately sure why it wasn't surfaced there. Unfortunately, I don't have more time today, but this could be something for a future explorer to take a look at.

@FrankieBurton can you verify that it is working now for you?

FrankieBurton commented 5 years ago

Hi @jszwedko,

It is working now! Thanks so much. What kind of technical skill does the SFPUC person need to have to have access to those credentials? Could you train them (when you're back from Spain)? If someone in Communications does not have the skills then someone in the IT department may.

Thanks so much! I hope Spain is great! :)

jszwedko commented 5 years ago

Hi @FrankieBurton,

The credentials are available via a web UI (Google API Console), but it is a little technical. I double checked that at least the Code for SF core team has access so that might be sufficient in terms of redundancy, but in terms of ownership let me know if you'd still like me to give access to someone (I'd just need an email address that is associated with a Google account). I'm happy to do a video call to quickly walk through the basics.

:es: is great!