search

sfbrigade / adopt-a-drain

A web application that allows citizens to "adopt" a storm drain in San Francisco. In use, and in development at other brigades. Looking for a maintainer or someone interested in developing further in collaboration with others across the country.
http://adoptadrain.sfwater.org/
BSD 3-Clause "New" or "Revised" License
44 stars 57 forks source link

Rubocop Rails Fix #413

Closed tonyta closed 5 years ago

tonyta commented 5 years ago

Problem

https://github.com/sfbrigade/adopt-a-drain/pull/408 caused a development/testing regression since updating Rubocop to 0.72.0 removed Rails linting support.

Solution

Add the rubocop-rails gem to restore missing Rails cops.

Other Changes

I made the following improvements while I had the Rubocop context:

Also, I just adopted my first drain today! 💜❤️🧡💛💚💙

coveralls commented 5 years ago

Coverage Status

Coverage remained the same at 97.924% when pulling 55a7de5e7831ed016f989baf4b46325a2b88cfe3 on tonyta:rubocop-fix into 945a0838da747370d03d49580ef14ffb25aa29b9 on sfbrigade:master.

jszwedko commented 5 years ago

Thanks for this! I completely missed that they moved Rails support out.

Also great to hear another drain being adopted!