search

sfbrigade / adopt-a-drain

A web application that allows citizens to "adopt" a storm drain in San Francisco. In use, and in development at other brigades. Looking for a maintainer or someone interested in developing further in collaboration with others across the country.
http://adoptadrain.sfwater.org/
BSD 3-Clause "New" or "Revised" License
44 stars 56 forks source link

Bump rubocop-rails from 2.4.2 to 2.5.2 #474

Closed dependabot-preview[bot] closed 4 years ago

dependabot-preview[bot] commented 4 years ago

Bumps rubocop-rails from 2.4.2 to 2.5.2.

Release notes

Sourced from rubocop-rails's releases.

RuboCop Rails 2.5.2

Bug fixes

  • #227: Make Rails/UniqueValidationWithoutIndex aware of updating db/schema.rb. (@koic)

RuboCop Rails 2.5.1

Bug fixes

  • #213: Fix a false positive for Rails/UniqueValidationWithoutIndex when using conditions. (@sunny)
  • #215: Fix a false positive for Rails/UniqueValidationWithoutIndex when using Expression Indexes. (@koic)
  • #214: Fix an error for Rails/UniqueValidationWithoutIndexwhen a table has no column definition. (@koic)
  • #221: Make Rails/UniqueValidationWithoutIndex aware of add_index in db/schema.rb. (@koic)

Changes

  • #223: Mark Rails/ApplicationController, Rails/ApplicationJob, Rails/ApplicationMailer, and Rails/ApplicationRecord as unsafe autocorrect. (@hoshinotsuyoshi)

RuboCop Rails 2.5.0

New features

  • #197: Add Rails/UniqueValidationWithoutIndex cop. (@pocke)
  • #208: Add new Rails/IndexBy and Rails/IndexWith cops. (@djudd, @eugeneius)
  • #150: Add EnforcedStyle: refute for Rails/RefuteMethods cop. (@koic)

Bug fixes

  • #180: Fix a false positive for HttpPositionalArguments when using get method with :to option. (@koic)
  • #193: Make Rails/EnvironmentComparison aware of Rails.env is used in RHS or when != is used for comparison. (@koic)
  • #205: Make Rails/ReversibleMigration aware of :to_table option of remove_foreign_key. (@joshpencheon)
  • #207: Fix a false positive for Rails/RakeEnvironment when using Capistrano. (@sinsoku)
Changelog

Sourced from rubocop-rails's changelog.

2.5.2 (2020-04-09)

Bug fixes

  • #227: Make Rails/UniqueValidationWithoutIndex aware of updating db/schema.rb. ([@koic][])

2.5.1 (2020-04-02)

Bug fixes

  • #213: Fix a false positive for Rails/UniqueValidationWithoutIndex when using conditions. ([@sunny][])
  • #215: Fix a false positive for Rails/UniqueValidationWithoutIndex when using Expression Indexes. ([@koic][])
  • #214: Fix an error for Rails/UniqueValidationWithoutIndexwhen a table has no column definition. ([@koic][])
  • #221: Make Rails/UniqueValidationWithoutIndex aware of add_index in db/schema.rb. ([@koic][])

Changes

  • #223: Mark Rails/ApplicationController, Rails/ApplicationJob, Rails/ApplicationMailer, and Rails/ApplicationRecord as unsafe autocorrect. ([@hoshinotsuyoshi][])

2.5.0 (2020-03-24)

New features

  • #197: Add Rails/UniqueValidationWithoutIndex cop. ([@pocke][])
  • #208: Add new Rails/IndexBy and Rails/IndexWith cops. ([@djudd][], [@eugeneius][])
  • #150: Add EnforcedStyle: refute for Rails/RefuteMethods cop. ([@koic][])

Bug fixes

  • #180: Fix a false positive for HttpPositionalArguments when using get method with :to option. ([@koic][])
  • #193: Make Rails/EnvironmentComparison aware of Rails.env is used in RHS or when != is used for comparison. ([@koic][])
  • #205: Make Rails/ReversibleMigration aware of :to_table option of remove_foreign_key. ([@joshpencheon][])
  • #207: Fix a false positive for Rails/RakeEnvironment when using Capistrano. ([@sinsoku][])
Commits
  • f30cf60 Cut 2.5.2
  • 885ecef Merge pull request #229 from koic/make_unique_validation_without_index_aware_...
  • 330f874 [Fix #227] Make Rails/UniqueValidationWithoutIndex aware of updating schema.rb
  • 02e73e4 Remove a redundant spec
  • 7a33464 Cut 2.5.1
  • 32791a6 Merge pull request #223 from hoshinotsuyoshi/application-controller-unsafe
  • a1aa7d5 Mark Rails/ApplicationController and similar cops as unsafe autocorrect
  • ad4e97d Merge pull request #222 from koic/make_unique_validation_without_index_aware_...
  • 3fa9c7c [Fix #221] Make Rails/UniqueValidationWithoutIndex aware of add_index
  • 3ba2b30 Merge pull request #218 from koic/fix_error_for_unique_validation_without_index
  • Additional commits viewable in compare view


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language - `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com): - Update frequency (including time of day and day of week) - Pull request limits (per update run and/or open at any time) - Automerge options (never/patch/minor, and dev/runtime dependencies) - Out-of-range updates (receive only lockfile updates, if desired) - Security updates (receive only security updates, if desired)
coveralls commented 4 years ago

Coverage Status

Coverage remained the same at 97.931% when pulling 01dbc0fa9c704b85f683431b8f268cb1f30a4628 on dependabot/bundler/rubocop-rails-2.5.2 into f7fee9544b87b5dd190245c4df7d77b45282304a on master.

dependabot-preview[bot] commented 4 years ago

Superseded by #487.