search

sfbrigade / adopt-a-drain

A web application that allows citizens to "adopt" a storm drain in San Francisco. In use, and in development at other brigades. Looking for a maintainer or someone interested in developing further in collaboration with others across the country.
http://adoptadrain.sfwater.org/
BSD 3-Clause "New" or "Revised" License
44 stars 57 forks source link

Bump rubocop-rails from 2.4.2 to 2.8.1 #491

Closed dependabot-preview[bot] closed 3 years ago

dependabot-preview[bot] commented 3 years ago

Bumps rubocop-rails from 2.4.2 to 2.8.1.

Release notes

Sourced from rubocop-rails's releases.

RuboCop Rails 2.8.1

Bug fixes

  • #345: Fix error of Rails/AfterCommitOverride on after_commit with a lambda. (@pocke)
  • #349: Fix errors of Rails/UniqueValidationWithoutIndex. (@Tietew)
  • #338: Fix a false positive for Rails/IndexBy and Rails/IndexWith when the each_with_object hash is used in the transformed key or value. (@eugeneius)
  • #351: Add <> operator to Rails/WhereNot cop. (@Tietew)
  • #352: Do not register offense if given a splatted hash. (@dvandersluis)
  • #346: Fix a false positive for Rails/DynamicFindBy when any of the arguments are splat argument. (@koic)
  • #357: Fix a false positive for Rails/ReversibleMigration when keyword arguments of change_column_default are in the order of to, from. (@koic)

RuboCop Rails 2.8.0

New features

  • #291: Add new Rails/SquishedSQLHeredocs cop. (@mobilutz)
  • #52: Add new Rails/AfterCommitOverride cop. (@fatkodima)
  • #323: Add new Rails/OrderById cop. (@fatkodima)
  • #274: Add new Rails/WhereNot cop. (@fatkodima)
  • #311: Make Rails/HelperInstanceVariable aware of memoization. (@koic)
  • #332: Fix Rails/ReflectionClassName cop false negative when relation had a scope parameter. (@bubaflub)

Bug fixes

  • #315: Allow to use frozen scope for Rails/UniqueValidationWithoutIndex. (@krim)
  • #313: Fix Rails/ActiveRecordCallbacksOrder to preserve the original callback execution order. (@eugeneius)
  • #319: Fix a false positive for Rails/Inquiry when #inquiry's receiver is a variable. (@koic)
  • #327: Fix Rails/ContentTag autocorrect to handle html5 tag names with hyphens. (@jaredmoody)

Changes

  • #312: Mark Rails/MailerName as unsafe for auto-correct. (@eugeneius)
  • #294: Update Rails/ReversibleMigration to register offenses for remove_columns and remove_index. ([@philcoggins][])
  • #310: Add EnforcedStyle to Rails/PluckInWhere. By default, it does not register an offense if pluck method's receiver is a variable. (@koic)
  • #320: Mark Rails/UniqBeforePluck as unsafe auto-correction. ([@kunitoo][])
  • #324: Make Rails/IndexBy and Rails/IndexWith aware of to_h with block. (@eugeneius)
  • #341: Make Rails/WhereExists configurable to allow where(...).exists? to be the prefered style. (@dvandersluis)
Changelog

Sourced from rubocop-rails's changelog.

2.8.1 (2020-09-16)

Bug fixes

  • #345: Fix error of Rails/AfterCommitOverride on after_commit with a lambda. ([@pocke][])
  • #349: Fix errors of Rails/UniqueValidationWithoutIndex. ([@Tietew][])
  • #338: Fix a false positive for Rails/IndexBy and Rails/IndexWith when the each_with_object hash is used in the transformed key or value. ([@eugeneius][])
  • #351: Add <> operator to Rails/WhereNot cop. ([@Tietew][])
  • #352: Do not register offense if given a splatted hash. ([@dvandersluis][])
  • #346: Fix a false positive for Rails/DynamicFindBy when any of the arguments are splat argument. ([@koic][])
  • #357: Fix a false positive for Rails/ReversibleMigration when keyword arguments of change_column_default are in the order of to, from. ([@koic][])

2.8.0 (2020-09-04)

New features

  • #291: Add new Rails/SquishedSQLHeredocs cop. ([@mobilutz][])
  • #52: Add new Rails/AfterCommitOverride cop. ([@fatkodima][])
  • #323: Add new Rails/OrderById cop. ([@fatkodima][])
  • #274: Add new Rails/WhereNot cop. ([@fatkodima][])
  • #311: Make Rails/HelperInstanceVariable aware of memoization. ([@koic][])
  • #332: Fix Rails/ReflectionClassName cop false negative when relation had a scope parameter. ([@bubaflub][])

Bug fixes

  • #315: Allow to use frozen scope for Rails/UniqueValidationWithoutIndex. ([@krim][])
  • #313: Fix Rails/ActiveRecordCallbacksOrder to preserve the original callback execution order. ([@eugeneius][])
  • #319: Fix a false positive for Rails/Inquiry when #inquiry's receiver is a variable. ([@koic][])
  • #327: Fix Rails/ContentTag autocorrect to handle html5 tag names with hyphens. ([@jaredmoody][])

Changes

  • #312: Mark Rails/MailerName as unsafe for auto-correct. ([@eugeneius][])
  • #294: Update Rails/ReversibleMigration to register offenses for remove_columns and remove_index. ([@philcoggins][])
  • #310: Add EnforcedStyle to Rails/PluckInWhere. By default, it does not register an offense if pluck method's receiver is a variable. ([@koic][])
  • #320: Mark Rails/UniqBeforePluck as unsafe auto-correction. ([@kunitoo][])
  • #324: Make Rails/IndexBy and Rails/IndexWith aware of to_h with block. ([@eugeneius][])
  • #341: Make Rails/WhereExists configurable to allow where(...).exists? to be the prefered style. ([@dvandersluis][])

2.7.1 (2020-07-26)

Bug fixes

  • #297: Handle an upstream Ruby issue where the DidYouMean module is not available, which would break the Rails/UnknownEnv cop. ([@taylorthurlow][])
  • #300: Fix Rails/RenderInline error on variable key in render options. ([@tejasbubane][])
  • #305: Fix crash in Rails/MatchRoute cop when via option is a variable. ([@tejasbubane][])

Changes

  • #301: Set disabled by default for Rails/PluckId. ([@koic][])
Commits
  • 2563954 Cut 2.8.1
  • 92c6828 Merge pull request #358 from koic/fix_false_positive_for_rails_reversible_mig...
  • 99515d0 [Fix #357] Fix a false positive for Rails/ReversibleMigration
  • 3ec7cda Merge pull request #346 from koic/fix_false_positive_for_dynamic_find_by
  • 01036ab Fix a false positive for Rails/DynamicFindBy
  • 13a0fbe Merge pull request #355 from koic/suppress_rubocop_offense
  • c9af0b5 Suppress RuboCop's offense
  • c2d3ade Merge pull request #354 from dvandersluis/fix-http-positional-kwspalt
  • 68e27a9 [Fix #352] Do not register an offense for Rails/HttpPositionalArguments whe...
  • 119bbaa Merge pull request #351 from Tietew/add_stdneq_wherenot
  • Additional commits viewable in compare view


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language - `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com): - Update frequency (including time of day and day of week) - Pull request limits (per update run and/or open at any time) - Automerge options (never/patch/minor, and dev/runtime dependencies) - Out-of-range updates (receive only lockfile updates, if desired) - Security updates (receive only security updates, if desired)
coveralls commented 3 years ago

Coverage Status

Coverage decreased (-90.7%) to 7.256% when pulling a47e4d48676153ead0ffd8df53de371668bb89b8 on dependabot/bundler/rubocop-rails-2.8.1 into f7fee9544b87b5dd190245c4df7d77b45282304a on master.

dependabot-preview[bot] commented 3 years ago

Superseded by #498.