sfbrigade / adopt-a-drain

A web application that allows citizens to "adopt" a storm drain in San Francisco. In use, and in development at other brigades. Looking for a maintainer or someone interested in developing further in collaboration with others across the country.
http://adoptadrain.sfwater.org/
BSD 3-Clause "New" or "Revised" License
44 stars 56 forks source link

Bump rubocop-rails from 2.4.2 to 2.9.1 #498

Closed dependabot-preview[bot] closed 3 years ago

dependabot-preview[bot] commented 3 years ago

Bumps rubocop-rails from 2.4.2 to 2.9.1.

Release notes

Sourced from rubocop-rails's releases.

RuboCop Rails 2.9.1

Bug fixes

  • #408: Fix bug in Rails/FindEach where config was ignored. (@ghiculescu)
  • #401: Fix an error for Rails/WhereEquals using only named placeholder template without replacement argument. (@koic)

Changes

  • #404: Make Rails/HelperInstanceVariable accepts of instance variables when a class which inherits ActionView::Helpers::FormBuilder. (@koic)
  • #406: Deconstruct "table.column" in Rails/WhereEquals. (@mobilutz)

RuboCop Rails 2.9.0

New features

  • #362: Add new Rails/WhereEquals cop. (@eugeneius)
  • #339: Add new Rails/AttributeDefaultBlockValue cop. (@cilim)
  • #344: Add new Rails/ArelStar cop which checks for quoted literal asterisks in arel_table calls. (@flanger001)
  • #389: Add IgnoredMethods config option for Rails/FindEach cop. (@tejasbubane)

Bug fixes

  • #371: Fix an infinite loop error for Rails/ActiveRecordCallbacksOrder when callbacks have inline comments. (@fatkodima)
  • #364: Fix a problem that Rails/UniqueValidationWithoutIndex doesn't work in classes defined with compact style. (@sinsoku)
  • #384: Mark unsafe for Rails/NegateInclude. (@koic)
  • #394: Fix false offense detection of Rails/RedundantAllowNil when using both allow_nil and allow_blank on different helpers of the same validator`. (@ngouy)

Changes

  • #383: Require RuboCop 0.90 or higher. (@koic)
  • #365: Mark Rails/SquishedSQLHeredocs unsafe for autocorrection. (@tejasbubane)

RuboCop Rails 2.8.1

Bug fixes

  • #345: Fix error of Rails/AfterCommitOverride on after_commit with a lambda. ([@pocke][])
  • #349: Fix errors of Rails/UniqueValidationWithoutIndex. ([@Tietew][])
  • #338: Fix a false positive for Rails/IndexBy and Rails/IndexWith when the each_with_object hash is used in the transformed key or value. (@eugeneius)
Changelog

Sourced from rubocop-rails's changelog.

2.9.1 (2020-12-16)

Bug fixes

  • #408: Fix bug in Rails/FindEach where config was ignored. ([@ghiculescu][])
  • #401: Fix an error for Rails/WhereEquals using only named placeholder template without replacement argument. ([@koic][])

Changes

  • #404: Make Rails/HelperInstanceVariable accepts of instance variables when a class which inherits ActionView::Helpers::FormBuilder. ([@koic][])
  • #406: Deconstruct "table.column" in Rails/WhereEquals. ([@mobilutz][])

2.9.0 (2020-12-09)

New features

  • #362: Add new Rails/WhereEquals cop. ([@eugeneius][])
  • #339: Add new Rails/AttributeDefaultBlockValue cop. ([@cilim][])
  • #344: Add new Rails/ArelStar cop which checks for quoted literal asterisks in arel_table calls. ([@flanger001][])
  • #389: Add IgnoredMethods config option for Rails/FindEach cop. ([@tejasbubane][])

Bug fixes

  • #371: Fix an infinite loop error for Rails/ActiveRecordCallbacksOrder when callbacks have inline comments. ([@fatkodima][])
  • #364: Fix a problem that Rails/UniqueValidationWithoutIndex doesn't work in classes defined with compact style. ([@sinsoku][])
  • #384: Mark unsafe for Rails/NegateInclude. ([@koic][])
  • #394: Fix false offense detection of Rails/RedundantAllowNil when using both allow_nil and allow_blank on different helpers of the same validator`. ([@ngouy][])

Changes

  • #383: Require RuboCop 0.90 or higher. ([@koic][])
  • #365: Mark Rails/SquishedSQLHeredocs unsafe for autocorrection. ([@tejasbubane][])

2.8.1 (2020-09-16)

Bug fixes

  • #345: Fix error of Rails/AfterCommitOverride on after_commit with a lambda. ([@pocke][])
  • #349: Fix errors of Rails/UniqueValidationWithoutIndex. ([@Tietew][])
  • #338: Fix a false positive for Rails/IndexBy and Rails/IndexWith when the each_with_object hash is used in the transformed key or value. ([@eugeneius][])
  • #351: Add <> operator to Rails/WhereNot cop. ([@Tietew][])
  • #352: Do not register offense if given a splatted hash. ([@dvandersluis][])
  • #346: Fix a false positive for Rails/DynamicFindBy when any of the arguments are splat argument. ([@koic][])
  • #357: Fix a false positive for Rails/ReversibleMigration when keyword arguments of change_column_default are in the order of to, from. ([@koic][])

2.8.0 (2020-09-04)

New features

Commits
  • addc9d3 Cut 2.9.1
  • 8d10c49 Merge pull request #406 from mobilutz/patch-1
  • 8e4425c Rails/WhereEquals add table/column split
  • 0728968 Merge pull request #407 from koic/make_rails_helper_instance_variable_accept_...
  • 4741d6b [Fix #404] Make Rails/HelperInstanceVariable accept of instance variables
  • 97c8578 Merge pull request #405 from koic/fix_an_error_for_rails_where_equals
  • 3eecd98 [Fix #401] Fix an error for Rails/WhereEquals
  • abbb4fa Merge pull request #408 from ghiculescu/find-each-bug
  • 0ffda34 Fix bug in Rails/FindEach
  • 151b8a6 Fix a build error
  • Additional commits viewable in compare view


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language - `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com): - Update frequency (including time of day and day of week) - Pull request limits (per update run and/or open at any time) - Automerge options (never/patch/minor, and dev/runtime dependencies) - Out-of-range updates (receive only lockfile updates, if desired) - Security updates (receive only security updates, if desired)
coveralls commented 3 years ago

Coverage Status

Coverage decreased (-90.7%) to 7.256% when pulling 2fb8873defa2a9849f2daecbc5e9af4566dc0ec6 on dependabot/bundler/rubocop-rails-2.9.1 into f7fee9544b87b5dd190245c4df7d77b45282304a on master.

dependabot-preview[bot] commented 3 years ago

Superseded by #519.