search

sfbrigade / bats-server

Routed is an app to help ambulances direct non-critical patients to hospital emergency rooms with the most availability.
https://routedapp.org/
GNU Affero General Public License v3.0
18 stars 12 forks source link

Bkretz/bug/tab scroll position #265

Closed kretzbryan closed 1 year ago

kretzbryan commented 1 year ago

For ticket #241

fwextensions commented 1 year ago

Can you rebase on main, or merge it in? I think it needs to be updated to work with the yarn workspaces.

fwextensions commented 1 year ago

Looks like there's an error when clicking the "Return to ringdown" button at the bottom of the hospital tab:

image

Guessing it's passing the old index number instead of an ID.

fwextensions commented 1 year ago

When testing this branch, I'm seeing each tab have different scroll positions now, but the ringdown scroll isn't getting restored when switching back to that tab. I scroll down most of the way on the ringdown form, then click the hospital tab, then click back, and the scroll position is back to near the top of the form.

fwextensions commented 1 year ago

The tabs don't seem to work in the ER view, I assume due a similar issue as the error above:

image

fwextensions commented 1 year ago

Nice, the propType and ER header bugs are fixed.

Can this be made to work in the ER tabs, as well?