Refactor field handling in Ringdown.js

sfbrigade / bats-server

Routed is an app to help ambulances direct non-critical patients to hospital emergency rooms with the most availability.

https://routedapp.org/

GNU Affero General Public License v3.0

18 stars 11 forks source link

Closed fwextensions closed 1 year ago

fwextensions commented 1 year ago

Ringdown.Fields was added in a previous PR, so use that instead of fieldHashes.
Simplify logic in setValidationStateForInput(), which didn't seem to depend on the current state.

fwextensions commented 1 year ago

Should we move this useForm custom hook to that directory?

I'd say no, as then the context would need to be exported, and it's not used anywhere else. This way, the only way to access it is through the hook.

I tend to keep hooks that are tied to a particular component in with the component code, but put generic ones in a separate directory.