search

sfbrigade / bats-server

Routed is an app to help ambulances direct non-critical patients to hospital emergency rooms with the most availability.
https://routedapp.org/
GNU Affero General Public License v3.0
18 stars 12 forks source link

EMS: Keyboard focus #282

Closed holliskuang closed 1 year ago

holliskuang commented 1 year ago

Reformatted how the Field/Selection components were structured

When the SelectHospital button is selected, the focus jumps to the buttons and seems to remain there for the newly rendered components.

Currently, it is set up as: {(Step 0) render } {(Step 1) render }

{(Step 0) render } {(Step 1) render }

A solution may be to restructure the Step 0s together, then the Step 1s together.

{(Step 0) render } {(Step 0) render }

{(Step 1) render } {(Step 1) render }

Therefore, when the Select Hospital Button is clicked, the next tab will naturally be the Hospital Selections without having to mess with tabIndex. Unsure if there are any unintended consequences with this, but everything seems to work fine on my side.

fwextensions commented 1 year ago

@francisli any idea why this branch isn't triggering the CircleCI build?

francisli commented 1 year ago

@francisli any idea why this branch isn't triggering the CircleCI build?

I think because this is in a fork, and not in a branch on the main repository.

@holliskuang I've invited you to be a collaborator on the repo, so you can push up new branches directly to it (which should trigger a CircleCI build).

https://github.com/sfbrigade/bats-server/invitations