search

sfbrigade / compass

Setting and tracking goals for students with disabilities
https://staging.compassiep.com/
14 stars 14 forks source link

Make Toast notification when CM adds staff [ENG] #240

Open tessathornberry opened 11 months ago

tessathornberry commented 11 months ago

On Hold until Designers and PMs can confirm.

Currently, when a CM adds a staff member, there is sometimes a noticeable delay before the staff member is added to the staff list. One of our engineers (Kendra!) noted that this was due to the length of time it took to do the tRPC call/mutation of input and possibly the delay in sending the invitation email.

One way to solve this being weird to users is to add a toast notification when a staff member is added that equates to "This staff member has been added to your staff list and an email invitation to join your caseload is being sent to them".

The few seconds that the toast notification is up might help the user be OK with the staff member's name not immediately appearing on the list.

Nkiriobasi commented 11 months ago

I will love to contribute, but what about a UI

tessathornberry commented 11 months ago

Hello, @Nkiriobasi !

Would love to have you on board again for what you can contribute! While the exact design for this use has not been created, the toast has. It is at our Figma Design System

And if you update your local copy of Compass, you can see the usage by searching for toast in the repo in VS Code. Please note that the Compass channels on Slack remain the best place to converse since not everyone gets GH notifications.

Nkiriobasi commented 11 months ago

Alright no problem, I will love to get an update once the design is created, so I can contribute. thank you.

tessathornberry commented 11 months ago

@Nkiriobasi Sounds good! I have this issue in the "on hold" column until the Hackathon next weekend, when many of the designers and a few engineers will hopefully be gathering in person. If you want to take an issue in the "To Dos" column, or create an issue to make the CSS of a component more closely match the designs, that would be a great contribution.

Nkiriobasi commented 11 months ago

Alright, that's fine.

amnak613 commented 2 weeks ago

I would like to take this on!

thomhickey commented 2 weeks ago

I would like to take this on!

Thanks @amnak613 ! ... I think this is in the blocked/on-hold swim lane until we re-focus efforts and zero in on a definitive mvp feature set. There will be discussion about this in tomorrow's (Tuesday) eng meeting where @tam-janice will meet with eng and refine what's next.