search

sfbrigade / datasci-SF-Environment-Benchmark

Set of applications to visualize SF building energy consumption and greenhouse gas emissions.
http://old.codeforsanfrancisco.org/datasci-SF-Environment-Benchmark/
12 stars 5 forks source link

74 benchmark compliance #77

Closed eayoungs closed 7 years ago

eayoungs commented 7 years ago

This is a temporary fix and does not close issue 74 but will work for the current release. I wouldn't normally do this but it will buy us a year for the SF Dept. of Environment, in which we can tackle revising the function, while we stay focussed on more pressing front-end issues.

thfield commented 7 years ago

@eayoungs I'm a little hesitant to just merge since some of these commits are months old... Since this is only addressing a fix for #74, do you think you could do a fresh pull from master and apply only the commit that changes latest_benchmark? It might be easier to close this PR and open a new one from a new branch

eayoungs commented 7 years ago

Yeah, I'm not sure where all those commits are coming from. I was trying to get back to using my fork, especially after accidentally pushing to @askiefer's PR branch. Let me see if I can clean this up later today. Thanks for calling me out on this; I'm a little scattered right now. Being pulled in several directions!