search

sfbrigade / datasci-SF-Environment-Benchmark

Set of applications to visualize SF building energy consumption and greenhouse gas emissions.
http://old.codeforsanfrancisco.org/datasci-SF-Environment-Benchmark/
12 stars 5 forks source link

ring chart edits: #97

Closed thfield closed 7 years ago

thfield commented 7 years ago

lower ranking means more filled in, code now in separate chart module, color scale reversed fixes #96 along with #73, will address #72

screen shot 2017-08-07 at 7 15 00 pm
askiefer commented 7 years ago

Actually @thfield maybe we should keep the ring chart and put the ranking (#9 out of 23) inside it for clarity (the #9 can be larger font on a separate line maybe). What do you think?

thfield commented 7 years ago

I'm conflicted in that Ii like having a ring chart but that isn't a good reason to hold it so precious....

I'll make that change and see what it looks like, maybe it'll be worth keeping around

(related to #98)

thfield commented 7 years ago

quick and dirty version:

screen shot 2017-08-10 at 1 48 20 pm
askiefer commented 7 years ago

Thanks @thfield! I don't mind it but will defer to you and @eayoungs. What do you both think?

thfield commented 7 years ago

let's implement #98 ~instead of~ on top of this PR for now;

feedback from DOE: Change out circle graphic to something similar to:

#5
Out of 15 Buildings
thfield commented 7 years ago

fixes #101

thfield commented 7 years ago

yeah, I think we should implement your solution in 98, which just displays the ranking without the ring chart. However, I want to first merge in this PR so the work of separating out the ring chart gets moved along and we can reuse it if we want a different ring chart somewhere