search

sfbrigade / datasci-SF-Environment-Benchmark

Set of applications to visualize SF building energy consumption and greenhouse gas emissions.
http://old.codeforsanfrancisco.org/datasci-SF-Environment-Benchmark/
12 stars 5 forks source link

Removed ring chart but added in local ranking #98

Closed askiefer closed 7 years ago

askiefer commented 7 years ago

Addresses issue #78 and maybe #72?

I took out the ring chart and added a local ranking text with a tooltip. The ring chart code is just commented out for now - @thfield I see that you added an issue to move it in to it's own file.

Also changed the right hand text from Estar score text to local ranking text.

screen shot 2017-08-09 at 12 01 09 am
askiefer commented 7 years ago

Awesome, thanks @thfield - I modified with your changes. I don't know whether we should keep the ring chart or not - on the one hang, I quite like it and it obviously adds a visual element otherwise missing but on the other hand idk if now it makes a whole lot of sense. What do you think? @eayoungs?

thfield commented 7 years ago

merge #97 before this to save separate ring chart code

askiefer commented 7 years ago

Fixed the merge conflicts on this one so it's ready (maybe be good to review it again @thfield ?) and then merge in #97 and then this.

thfield commented 7 years ago

I'll merge 97 and take another look at this