search

sfbrigade / datasci-sba

Solving problems with the Small Business Administration
10 stars 18 forks source link

udpated sql for table comments #27

Open gregboyer opened 7 years ago

gregboyer commented 7 years ago

I still suck at git. Gotta git add before I git commit! This has additional comments for all SBA related tables and columns

VincentLa14 commented 7 years ago

Would you mind making pipeline/pipeline_tasks/documentation/table_comments into a sql file? You can just rename it to table_comments.sql. This way we can just execute the SQL commands inside the file.

Also do you mind adding the table_comments.sql file to run within https://github.com/sfbrigade/datasci-sba/blob/master/pipeline/pipeline_runner.py.

You'll likely just want to add it as another element in the list: https://github.com/sfbrigade/datasci-sba/blob/master/pipeline/pipeline_runner.py#L100

VincentLa14 commented 7 years ago

hmm might need to be careful with merge conflicts now that @zlatankr has renamed pipeline/pipeline_tasks/documentation/table_comments