search

sfbrigade / datasci-sba

Solving problems with the Small Business Administration
10 stars 18 forks source link

adding a business question and notes on irs and census data #46

Open gregboyer opened 7 years ago

gregboyer commented 7 years ago

1. Brief Summary of what this PR accomplishes (140 characters or less. If you find trouble describing what you are doing in this length, consider breaking the PR into multiple ones.)

Updates documentation on additional data sources (mean agi from IRS and # small businesses from census, added question to business notes doc)

2. Link to Trello Ticket https://trello.com/c/WgR9FXLv

3. More detailed description and other questions to address in code review Nothing specific to address

4. Remember to tag reviewers!

gregboyer commented 7 years ago

Got a recommended line length? I’m sure I can wrap in sublime.

On Aug 22, 2017, at 10:10 PM, Michael Mathews notifications@github.com wrote:

@makfan64 commented on this pull request.

The only thing I don't like is the formatting in 01_exploring_the_data.md. A bunch of lines require using the horizontal scrollbar, which I would avoid if at all possible.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/sfbrigade/datasci-sba/pull/46#pullrequestreview-57974546, or mute the thread https://github.com/notifications/unsubscribe-auth/AcYKr8c4Gkum56PPcv9QrJRZZsM6aBlwks5sa7Q_gaJpZM4O_doR.

makfan64 commented 7 years ago

I wonder why it didn't wrap like the rest of the text? Usually 80ish is recommended, but most text wraps based on the browser width.

gregboyer commented 7 years ago

What are you opening it in? I’m curious. Not seeing any issues in Sublime.

On Aug 22, 2017, at 10:28 PM, Michael Mathews notifications@github.com wrote:

I wonder why it didn't wrap like the rest of the text? Usually 80ish is recommended, but most text wraps based on the browser width.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/sfbrigade/datasci-sba/pull/46#issuecomment-324225063, or mute the thread https://github.com/notifications/unsubscribe-auth/AcYKr2HpKL8stcfeApzTIKD84GlHZYSLks5sa7h3gaJpZM4O_doR.

makfan64 commented 7 years ago

I viewed it from the "code" tab in Chrome.

https://github.com/sfbrigade/datasci-sba/blob/data_notes/onboarding/01_exploring_the_data.md (after selecting branch data_notes).

makfan64 commented 7 years ago

It might just be that the numbered lines start with spaces. I think four leading spaces forces Markdown to format like a code snippet.

SuperNerb commented 7 years ago

That’s correct Vince. The SBA updates the online dataset once a quarter.

From: VincentLa14 [mailto:notifications@github.com] Sent: Thursday, August 24, 2017 9:36 AM To: sfbrigade/datasci-sba Cc: Brod, Noah; Mention Subject: Re: [sfbrigade/datasci-sba] adding a business question and notes on irs and census data (#46)

@VincentLa14 commented on this pull request.

In business_notes.mdhttps://github.com/sfbrigade/datasci-sba/pull/46#discussion_r135066848:

@@ -28,3 +29,9 @@

     * NOT FUNDED - undetermined loan not funded.

     * Undisbursed comes before cancelled

+

+

+

+Questions:

+1. What is the SBA data refresh cycle like? Does all of the source data need to be up-to-date? Once a year?

@SuperNerbhttps://github.com/supernerb I think mentioned that SBA releases updates to the FOIA loan data sets once a quarter?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/sfbrigade/datasci-sba/pull/46#pullrequestreview-58436696, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AURGe_p7by4dxtC8HeplKS563lJJAtbOks5sbaZXgaJpZM4O_doR.