search

sfbrigade / datasci-sba

Solving problems with the Small Business Administration
10 stars 18 forks source link

Adding Congressional District Data #55

Closed VincentLa closed 7 years ago

VincentLa commented 7 years ago

1. Brief Summary of what this PR accomplishes (140 characters or less. If you find trouble describing what you are doing in this length, consider breaking the PR into multiple ones.)

Hits Google Civic API to add congressional district data to our database

2. Link to Trello Ticket

https://trello.com/c/aKvxFeZF/36-get-congressional-districts-and-counties-for-borrower-data-this-is-to-identify-county-and-congressional-district-for-each-addres

3. More detailed description and other questions to address in code review

We use Google Civic API to add congressional district data to our database. Note that you will have to have an environment variable GOOGLEAPI to run this code. See https://developers.google.com/civic-information/ for more information about Google Civic API

Also added an example of a test for the python function that runs the API call.

4. Remember to tag reviewers! @makfan64

makfan64 commented 7 years ago

I think we should close this as PR 72 addresses this and all the other API calls.