search

sfbrigade / datasci-sba

Solving problems with the Small Business Administration
10 stars 18 forks source link

Setup #62

Closed amituuush closed 7 years ago

amituuush commented 7 years ago

1. Brief Summary of what this PR accomplishes (140 characters or less. If you find trouble describing what you are doing in this length, consider breaking the PR into multiple ones.)

created yarn.lock file, installed eslint required packages, added airbnb preset to babelrc, installed sass-loader, added style guide links to onboarding and web_app readme

2. Link to Trello Ticket https://trello.com/c/mvc2jv06/66-add-in-yarn https://trello.com/c/l0rh5qM5/65-set-up-automatic-linting-using-eslint https://trello.com/c/E0tqGyET/72-add-in-sass-loader https://trello.com/c/Ax65IAYL/67-add-link-to-airbnb-style-guide-to-and-python-style-guide

3. More detailed description and other questions to address in code review I recommend going through the following tutorial (takes 3 min) to get caught up to speed on basic CLI commands and workflow (very simple and straightforward). https://yarnpkg.com/en/docs/yarn-workflow

Not exactly sure how this is going to affect CI. We may need to toy around with it, but it's definitely compatible.

4. Remember to tag reviewers! @avdonovan

avdonovan commented 7 years ago

Looks good! I replaced some references to NPM with references to Yarn in the doc files, also moved the list of styleguides to the root "development environment" doc since we should also list styleguides for other parts of the repo like the python & SQL stuff