search

sfbrigade / datasci-sba

Solving problems with the Small Business Administration
10 stars 18 forks source link

September mvp #70

Closed avdonovan closed 6 years ago

avdonovan commented 6 years ago

1. Brief Summary of what this PR accomplishes (140 characters or less. If you find trouble describing what you are doing in this length, consider breaking the PR into multiple ones.)

Includes all the frontend changes for the September MVP, and changes the backend to use data from the manually cleaned Excel file.

2. Link to Trello Ticket

3. More detailed description and other questions to address in code review

4. Remember to tag reviewers!

makfan64 commented 6 years ago

Any reason not to merge this? I'm working on a branch from main and it's way, way out of date. @VincentLa @amituuush

VincentLa14 commented 6 years ago

generally looks good to me, and it obviously "works" as the MVP. Won't be able to give a super detailed review as I'm unfamiliar with a lot of the front end technologies here, but again it does seem mostly good to me.