search

sfbrigade / sf-crime-data

Search SFPD incidents from SF OpenData with focus on campus safety.
http://sfcrimedata.org
MIT License
26 stars 39 forks source link

Complete code hygiene, use best practices for javascript #19

Closed jasonlally closed 8 years ago

jasonlally commented 8 years ago

From Tamas:

Due to fast prototyping (as I know) the code is now a spaghetti code. Lets add some structure to it. Use Javascript Design Patterns like the revealing module patternto create a strong code foundation for this project! There could be private or public modules depending on where we'd like to use the function in question. For a well structured application with revealing module pattern see http://harbourstudios.com/fulfillment/brookfield_locator/ from my portfolio

jasonlally commented 8 years ago

Totally agree here. I'll defer to you on best practice. I think a revealing module pattern could work. Something easy to maintain and for other folks to jump into. I'd say this is top priority for me as it'll set the codebase up to be easier to maintain in the long run.

jasonlally commented 8 years ago

@searoutefinder - saw you started this and it's much better now than before 👍

jasonlally commented 8 years ago

This is addressed by #20