search

sfbrigade / sfbrigade.github.io.2017-11-05

[DEPRECATED] The Code for San Francisco website.
38 stars 76 forks source link

Allow local development without internet access #54

Closed cjerdonek closed 8 years ago

cjerdonek commented 9 years ago

As I discussed in person with @jasonlally last night, it would be nice if one could run jekyll serve without an internet connection. I found this out when trying to test my PR on Muni :light_rail: :grinning:

Fixing this would involve having files like Bootstrap downloaded locally instead of being served from a CDN in the development environment.

jszwedko commented 9 years ago

This is a good idea, thanks for raising the issue @cjerdonek . I'll take a shot at a PR for it.

ralphreid commented 8 years ago

Hiya jszwedko - need any help on this one?

jszwedko commented 8 years ago

@ralphreid I completely forgot I had this open, I would love some help if you want to take it on. I didn't end up getting the chance to work on it at the time.

ralphreid commented 8 years ago

Hi Jesse,

Cool, happy to take crack at that. Would it be ok if it was baked into a vagrant / puppet solution. Do you think anyone else would use this feature?

New to the project and keen to help, so ping me in slack to and we can discuss further.

Best.

On 15 Jan 2016, at 21:01, Jesse Szwedko notifications@github.com wrote:

@ralphreid I completely forgot I had this open, I would love some help if you want to take it on. I didn't end up getting the chance to work on it at the time.

— Reply to this email directly or view it on GitHub.

cjerdonek commented 8 years ago

Personally, vagrant seems like overkill to me and also wouldn't address the issue of files like Bootstrap being served from a CDN, which is what was causing this issue.

jszwedko commented 8 years ago

Awesome @ralphreid !

I tend to agree with @cjerdonek that Vagrant may be a little overkill for this project which has so few dependencies (just Ruby and Jekyll). I was initially thinking maybe we could just have Jekyll conditionally include <script src=""> and <stylesheet> tags pointing at vendored copies, when building, if running locally; however, this raises the question of how would we ensure that we are keeping the local copies up-to-date with what we specify.

Given the tradeoffs, I'm inclined to say that we just vendor and serve all of our dependencies. Github pages (which is where this is hosted) already runs on a CDN, so we aren't gaining a ton by referencing assets on other CDNs (simply that users that are lucky enough to already have that file from the other CDN will see a speed-up).

Let me know what you think!

jszwedko commented 8 years ago

Fixed by #153