search

sfbrigade / support-sfusd

Support SF Schools web site (dev deployment at: https://support-sfusd.vercel.app)
https://supportsfschools.org
5 stars 2 forks source link

inconsistent resizing in list view #224

Open juliagoolia opened 2 weeks ago

juliagoolia commented 2 weeks ago

if you scroll down through the list view (both desktop and mobile) and open the school cards, sometimes they open consistently, but sometimes (especially if you scroll to the bottom and then expand them as you scroll up) they don't. here's a link to a recording: https://sfbrigade.slack.com/files/U01JYKWN43D/F07L5J83AQ2/rpreplay_final1725567192.mp4

thomhickey commented 1 week ago

Hi @juliagoolia ... seems to work as expected to me and I can't tell from the video which schools you are clicking/tapping on so it's hard to see what the problem is there as well. Happy to fix this once I can reproduce it!

juliagoolia commented 1 week ago

hey @thomhickey thanks for looking into it. if you go to the list view and scroll to the very bottom and expand the last school, what do you see? i have another recording that's too big to upload to github. but if i scroll to the bottom and start expanding schools from the bottom of the list going up, none of them show the "learn more" button.

thomhickey commented 1 week ago

@juliagoolia yeah I can get it to behave wonky, but it takes some doing. most of what i'm seeing is what you noticed in your other bug that the learn more button doesn't scroll into view always (#226) ... which I have fixed in a branch, but i'm not happy with the heavy lifting that was necessary to fix it so i'm fine tuning the code some more.

thomhickey commented 1 week ago

hi @juliagoolia ... is this fixed in PR #228 ?