Closed Naphann closed 1 year ago
The error parameter of a stationary qubit is confusing with the "rate" vs "ratio". Currently the StationaryQubit.memory_error_rate is unused and misleads users to think that setting it to 0 means we have perfect memory.
StationaryQubit.memory_error_rate
0
https://github.com/sfc-aqua/quisp/blob/db34b8f704746c6180e538c79d2844fd1c4ad91d/quisp/modules/QNIC/StationaryQubit/StationaryQubit.ned#L60-L77
Currently, the ratio keyword for memory error is unused and we are supposed to treat the rate and ratio correctly.
ratio
In order to properly and correctly build the transition matrix as done in the initialization process of StationaryQubit (below)
https://github.com/sfc-aqua/quisp/blob/db34b8f704746c6180e538c79d2844fd1c4ad91d/quisp/modules/QNIC/StationaryQubit/StationaryQubit.cc#L42-L60
We should remove unused parameters which can cause conflict or misunderstanding to users.
Examples of things that should be removed (suggested):
The error parameter of a stationary qubit is confusing with the "rate" vs "ratio". Currently the
StationaryQubit.memory_error_rate
is unused and misleads users to think that setting it to0
means we have perfect memory.https://github.com/sfc-aqua/quisp/blob/db34b8f704746c6180e538c79d2844fd1c4ad91d/quisp/modules/QNIC/StationaryQubit/StationaryQubit.ned#L60-L77
Currently, the
ratio
keyword for memory error is unused and we are supposed to treat the rate and ratio correctly.In order to properly and correctly build the transition matrix as done in the initialization process of StationaryQubit (below)
https://github.com/sfc-aqua/quisp/blob/db34b8f704746c6180e538c79d2844fd1c4ad91d/quisp/modules/QNIC/StationaryQubit/StationaryQubit.cc#L42-L60
We should remove unused parameters which can cause conflict or misunderstanding to users.
Examples of things that should be removed (suggested):