search

sfc-gh-klochen / sfsnowsightextensions

Snowflake Snowsight Extensions enables manipulation of Snowsight features from command-line
6 stars 1 forks source link

Wrong value for the OAuthNonce logged into debug output #30

Closed danielodievich closed 1 year ago

danielodievich commented 1 year ago

I made a mistake which parameter I logged for the OAuthNonce.

In https://github.com/Snowflake-Labs/sfsnowsightextensions/blob/main/Commands/Authentication/ConnectAppCommand.cs#L301 currently:

                logger.Info("OAuthNonce={0}", deploymentSnowSightClientIDRedirectResult.Item1);

should be

                // The nonce gets passed from the cookie
                logger.Info("OAuthNonce={0}", deploymentSnowSightClientIDRedirectResult.Item2);
sfc-gh-mybarra commented 1 year ago

Thanks, Daniel. I made the update. I will be creating a new release shortly.